Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moshi-adapters module #462

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Add moshi-adapters module #462

merged 1 commit into from
Dec 18, 2021

Conversation

SimonMarquis
Copy link
Contributor

πŸš€ Description

Add moshi-adapters module.

πŸ“„ Motivation and Context

Closes #461

πŸ§ͺ How Has This Been Tested?

./gradlew clean check βœ…

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

@LouisCAD
Copy link
Member

LouisCAD commented Dec 6, 2021

Hello Simon,
Thanks for submitting the issue and this PR!

I apologize for the radio silence. I plan to review this before the next release.

I'm just very busy with #460 for this project, and I want to get it done before moving on (BTW, if you want to help in a pairing session on that one, let me know).

Copy link
Member

@LouisCAD LouisCAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@LouisCAD LouisCAD merged commit 55e27e8 into Splitties:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing dependency for moshi-adapters
2 participants