-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag versions #21
Comments
See angular-cache/tags. What is it about the tags that isn't to your liking? And what do you mean by "pinned"? Are you using raw.github.com as a CDN? Drone.io archives the artifacts of each successful build. You can find them at drone.io. There is a file that isn't versioned, though it isn't minified. See src/angular-cache.js. It isn't good practice to depend on a 3rd-party library that isn't versioned. See how Google Hosted Libraries (CDN) does it as a reference. The intention of |
Sorry, I should have been more explicit - I'm using bower for dependency
Okay, that should work, any chance of updating the bower.json 'main'
Yeah, if your only method of dependency management is the script Anyway, I can just modify the way I reference this lib to use the file |
Ah. While I had published angular-cache to bower, I hadn't actually looked at how bower handles versions. I had assumed that it was similar to npm, where you specify the version you're publishing. From now on I will name my tags strictly with semver. I will keep the versioned output files around for those who don't use Bower, but update bower.json to use the un-versioned file. |
Great, thanks, one problem though - Semver also defines a standard notation for alpha/beta/rc releases too. You don't have to use it, but it makes tag history more readable IMO. |
Good catch. The bower stuff should be fixed up for you now. |
Please tag versions so that they can be pinned. Also, it would be nice if the output filenames were not versioned (ie -
angular-cache.js
/angular-cache.min.js
rather thanangular-cache-n.n.n.js
), so that references don't have to change with an update.The text was updated successfully, but these errors were encountered: