Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on github.com/dgryski/go-metro #2

Closed
tamird opened this issue Jan 8, 2018 · 2 comments
Closed

Remove dependency on github.com/dgryski/go-metro #2

tamird opened this issue Jan 8, 2018 · 2 comments

Comments

@tamird
Copy link

tamird commented Jan 8, 2018

github.com/dgryski/go-metro is written largely in gc-syntax assembly, which makes it difficult to support gccgo downstream of it. It would be better if this library (which is used by github.com/golang/dep) did not depend on it.

cc @sdboyer

@jmank88
Copy link
Owner

jmank88 commented Jan 8, 2018

go-metro is only imported by the cmd/testpaths package, which is called via go:generate from paths_test, so perhaps this can be worked around. On the other hand, its only minimally used and can likely be replaced by any old relatively uniform hash.

@tamird
Copy link
Author

tamird commented Jan 8, 2018

Right. Why not use the stdlib's hash/fnv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants