From 01de894f4723ad92bf0c2f17fc0387265d44eeae Mon Sep 17 00:00:00 2001 From: James Melville Date: Sat, 16 Jul 2022 15:24:38 -0700 Subject: [PATCH] Update for new submission --- .Rbuildignore | 1 + DESCRIPTION | 2 +- NEWS.md | 2 +- cran-comments.md | 48 ++++++++++++++++++++++++------------------------ 4 files changed, 27 insertions(+), 26 deletions(-) diff --git a/.Rbuildignore b/.Rbuildignore index 85e0da8..08601f3 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -9,3 +9,4 @@ ^cran-comments\.md$ DONTCHECKMEIN.R ^\.github$ +^CRAN-SUBMISSION$ diff --git a/DESCRIPTION b/DESCRIPTION index 6a1c968..fe2edb3 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: RcppHNSW Title: 'Rcpp' Bindings for 'hnswlib', a Library for Approximate Nearest Neighbors -Version: 0.3.0.9001 +Version: 0.4.0 Authors@R: c(person("James", "Melville", email = "jlmelville@gmail.com", role = c("aut", "cre")), person("Aaron", "Lun", role = "ctb"), diff --git a/NEWS.md b/NEWS.md index 312baec..a9d6f56 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# RcppHNSW 0.3.0.9000 +# RcppHNSW 0.4.0 ## New features diff --git a/cran-comments.md b/cran-comments.md index 84891cb..ac2558f 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,50 +1,50 @@ ## Release Summary -This is a new minor release. +This is a new minor release and also fixes a 'LazyData' NOTE reported on the +CRAN checks page. ## Test environments -* ubuntu 16.04 (on travis-ci), R 3.6.3, R 4.0.0, R-devel -* ubuntu 16.04 (on rhub), R 3.6.1 -* fedora 32 (on rhub), R-devel -* mac OS X High Sierra (on travis-ci), R 3.6.3, R 4.0.2 -* local Windows 10 build, R 4.0.2 -* Windows Server 2008 (on rhub) R-devel -* Windows Server 2012 (on appveyor) R 4.0.2 +* ubuntu 20.04 (on github actions), R 4.1.3, R 4.2.1, devel +* local ubuntu 22.04 R 4.2.1 +* Windows Server 2022 (on github actions), R 4.1.3 +* local Windows 11 build, R 4.2.1 +* mac OS X Big Sur (on github actions) R 4.2.1 * win-builder (devel) ## R CMD check results There were no ERRORs or WARNINGs. +There was one NOTE: + +❯ checking installed package size ... NOTE + installed size is 5.4Mb + sub-directories of 1Mb or more: + libs 5.1Mb + +This is expected due to the use of C++ templates in hnswlib. + There was a message about possibly mis-spelled words in DESCRIPTION: HNSW (2:28) This is spelled correctly. -With r-hub checking on Debian, there was the following message: - -> * checking installed package size ... NOTE - installed size is 7.3Mb - sub-directories of 1Mb or more: - libs 7.1Mb - -This is expected due to the use of C++ templates in HNSW. - ## CRAN checks There are no ERRORs or WARNINGs. -There are three flavors with NOTEs about installed package size -(r-devel-linux-x86_64-fedora-clang, r-release-macos-x86_64, +There is a NOTE for all flavors about LazyData. This release fixes that NOTE. + +There are four flavors with NOTEs about installed package size +(r-release-macos-arm64, r-release-macos-x86_64, r-oldrel-macos-arm64, r-oldrel-macos-x86_64). This is expected and won't be fixed. ## Downstream dependencies -There are 2 reverse dependencies (0 from CRAN + 2 from BioConductor): +We checked 3 reverse dependencies (1 from CRAN + 2 from Bioconductor), comparing +R CMD check results across CRAN and dev versions of this package. -* BiocNeighbors has no ERRORs or WARNINGs. -* Destiny fails to complete the R CMD check due to problems building vignettes. -This is unrelated to either the current CRAN version of RcppHNSW or this new -release. + * We saw 0 new problems + * We failed to check 0 packages