Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs when page height changes #569

Open
kannafay opened this issue Feb 24, 2024 · 9 comments
Open

Bugs when page height changes #569

kannafay opened this issue Feb 24, 2024 · 9 comments

Comments

@kannafay
Copy link

I have found that when the height of a webpage changes, the location of the trigger will change, and even using sync() can cause bugs

This is a normal situation:

bug.mp4

This is the effect of using ScrollReveal().sync()

bug

bug-sync.mp4

I don't know what's wrong. I trigger ScrollReveal().sync() when I click collapse panel, but it seems that something's wrong with it

Environment

  • Operating System: Windows 11
  • Browser Version: Google Chrome 121.0.6167.189
  • ScrollReveal Version: v4.0.9
@kannafay
Copy link
Author

hi bro ,who can help me

@GeistFighter
Copy link

Hello, I have the same problem 😥
Have you found a solution ?

@GeistFighter
Copy link

same problem here #565

@kannafay
Copy link
Author

same problem here #565

However, it does not solve my problem

@kannafay
Copy link
Author

same problem here #565

I need to recalculate the height when triggered, but it doesn't take effect

@GeistFighter
Copy link

GeistFighter commented May 16, 2024

I found the function ScrollReveal().delegate(); which I use instead of ScrollReveal().sync(); and it now works for me, as if it recalculates the size

@GeistFighter
Copy link

#567

@kannafay
Copy link
Author

kannafay commented Dec 6, 2024

@GeistFighter Let me try, bro.

@kannafay
Copy link
Author

kannafay commented Dec 6, 2024

@GeistFighter Bro, it's very nice!!!
delegate() solved my problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants