Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort cluster by name is the settings #83

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

angelozerr
Copy link
Collaborator

Sort cluster by name is the settings

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Collaborator Author

angelozerr commented Jan 15, 2021

This PR sort cluster names in the clusterSettings#getAll instead of sorting cluster in the kafka model (used only by explorer). It gives the capability to display cluster in wizard sorted by name.

Here is a screenshot where abcd is created after my-cluster:

image

@angelozerr angelozerr requested a review from fbricon January 15, 2021 09:05
@angelozerr angelozerr force-pushed the sort-cluster-in-settings branch from e5fc12e to 9d97877 Compare January 15, 2021 09:14
@angelozerr angelozerr self-assigned this Jan 15, 2021
@angelozerr angelozerr added this to the 0.11.0 milestone Jan 15, 2021
@angelozerr angelozerr added the enhancement New feature or request label Jan 15, 2021
@fbricon
Copy link
Collaborator

fbricon commented Jan 18, 2021

please update the readme

@angelozerr angelozerr force-pushed the sort-cluster-in-settings branch from 9d97877 to 7f4c46e Compare January 18, 2021 10:24
@angelozerr
Copy link
Collaborator Author

please update the readme

I have updated the README, please tell me if it's OK.

@angelozerr angelozerr force-pushed the sort-cluster-in-settings branch from 7f4c46e to 3de399e Compare January 18, 2021 10:26
README.md Outdated Show resolved Hide resolved
@angelozerr angelozerr force-pushed the sort-cluster-in-settings branch 2 times, most recently from b0dd97d to 94fd46d Compare January 18, 2021 11:58
@fbricon fbricon merged commit 22692a5 into jlandersen:master Jan 18, 2021
@fbricon
Copy link
Collaborator

fbricon commented Jan 18, 2021

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants