add reader support for MSFT_texture_dds extension #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds required support to read this extension. Doesn't add the writer support.
|
Seems like they won't add vendor extensions to the official gLTF-Sample repo. Dropping this PR for now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds basic support to read this extension. Doesn't add the writer support.
(This extension is a draft, so not sure if you'd accept this, but would be nice to read DDS using this lib)
There is a pending PR to add a model with this extension in the gLTF-Sample repo (KhronosGroup/glTF-Sample-Models#378).
Fixes #203