Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Diff #47

Merged
merged 22 commits into from
Oct 23, 2023
Merged

Image Diff #47

merged 22 commits into from
Oct 23, 2023

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Aug 30, 2023 •
edited
Loading

Closes #46

Add Detail Diff for Images with

  • pixel based difference between two images using JS build of OpenCV
  • Similarity metrics for the images
    • ORB similarty
    • Pixel based similarity (i.e. how many % of the pixels are identical)

Side-by-Side Diff:
image

Unified Diff:
unified diff loops

@keckelt
set active cell on start
2492ece 
avoids seemingly empty extension if a notebook already has some provenance
@keckelt keckelt added the enhancement New feature or request label Aug 30, 2023
@keckelt keckelt self-assigned this Aug 30, 2023
@github-actions
Copy link

Binder 👈 Launch a Binder on branch jku-vds-lab/loops/46-img-diff

keckelt added 21 commits August 30, 2023 07:31
@keckelt
fix padding between input and label
cc6d341
@keckelt
show content of active cells
8016375 
remove transparent coloring of text
@keckelt
remove todo
cf355e4
@keckelt
organize imports
1b3936f
@keckelt
Add tabs to detail diff
682356f 
show diff of text outputs
@keckelt
scroll to most recent states initially
d641b61
@keckelt
remove console log
7a92519
@keckelt
Remove firefox launch debug config
8944052
@keckelt
set active cell on notebook change
93fd19a 
in order to scroll to it
@keckelt
Refactor MonacoEditor in new file
ad5dc25
@keckelt
add styles to new file
aef77ec
@keckelt
Show imgs side by side
c8b5d5d
@keckelt
calculate image diffs
e7426f6
@keckelt
calculate img similartiy pt 1
fc1660f
@keckelt
image similarity metrics with openCV
8748b62
@keckelt
switch back to techstark/opencv-js
4b2100d
@keckelt
IT WORKS !!!
cef2767
@keckelt
update prettierignore for opencv and notebooks
9d57306
@keckelt
switch to library hosted by opencv
aa21073
@keckelt
remove debug logs
5bd1500
@keckelt
Add similarity measures
df9b582
@keckelt keckelt marked this pull request as ready for review October 23, 2023 11:20
@keckelt keckelt merged commit 3014736 into main Oct 23, 2023
7 checks passed
@keckelt keckelt deleted the 46-img-diff branch October 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keckelt keckelt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detail Diff: Images
1 participant
@keckelt