Skip to content

Commit

Permalink
Image Diff (#47)
Browse files Browse the repository at this point in the history
* set active cell on start
avoids seemingly empty extension if a notebook already has some provenance

* fix padding between input and label

* show content of active cells
remove transparent coloring of text

* remove todo

* organize imports

* Add tabs to detail diff
show diff of text outputs

* scroll to most recent states initially

* remove console log

* Remove firefox launch debug config

* set active cell on notebook change
in order to scroll to it

* Refactor MonacoEditor in new file

* add styles to new file

* Show imgs side by side

* calculate image diffs

* calculate img similartiy pt 1

* image similarity metrics with openCV

* switch back  to techstark/opencv-js

* IT WORKS !!!

* update prettierignore for opencv and notebooks

* switch to library hosted by opencv

* remove debug logs

* Add similarity measures
  • Loading branch information
keckelt authored Oct 23, 2023
1 parent 1762a6e commit 3014736
Show file tree
Hide file tree
Showing 18 changed files with 1,365 additions and 176 deletions.
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ node_modules
**/lib
**/package.json
!/package.json
chat.json
coverage
loops
notebooks
src/opencv/opencv-4.8.0.js
32 changes: 13 additions & 19 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,20 @@
"version": "0.2.0",
"configurations": [
{
"name": "Firefox",
"type": "firefox",
"request": "attach",
"name": "Attach to Firefox",
"url": "http://localhost:13013/lab?"
"request": "launch",
"reAttach": false,
"url": "http://localhost:13013/lab?",
"profile": "dev-edition-default",
"keepProfileChanges": true,
"pathMappings": [
{
"url": "webpack://${workspaceFolderBasename}/",
"path": "${workspaceFolder}/"
}
],
"webRoot": "${workspaceFolder}"
},
{
"type": "node",
Expand All @@ -32,22 +42,6 @@
"program": "${workspaceFolder}/node_modules/jest/bin/jest"
}
},
{
"name": "Firefox",
"type": "firefox",
"request": "launch",
"reAttach": false,
"url": "http://localhost:13013/lab?",
"profile": "dev-edition-default",
"keepProfileChanges": true,
"pathMappings": [
{
"url": "webpack://${workspaceFolderBasename}/",
"path": "${workspaceFolder}/"
}
],
"webRoot": "${workspaceFolder}"
},
{
"name": "JupyterLab backend",
"type": "python",
Expand Down
22 changes: 15 additions & 7 deletions notebooks/demo.ipynb

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@
"jupyterlab": {
"extension": true,
"outputDir": "loops/labextension",
"schemaDir": "schema"
"schemaDir": "schema",
"webpackConfig": "./webpack.config.js"
},
"eslintIgnore": [
"node_modules",
Expand Down Expand Up @@ -262,7 +263,7 @@
"max-len": [
"error",
{
"code": 120,
"code": 160,
"comments": 180
}
],
Expand Down
Loading

0 comments on commit 3014736

Please sign in to comment.