Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for referenced valueFiles in multiple sources ArgoCD applications #319

Closed
almereyda opened this issue Jan 12, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@almereyda
Copy link
Contributor

Problem Statement

When using the new ArgoCD multiple sources applications argoproj/argo-cd#10432, one can reference (ref: source1) one source within e.g. the valueFiles of another with a shorthand flag $source1/values.yaml.

This notation is currently not supported by Helm Secrets.

Proposed Solution

Helm Secrets also works in multiple sources applications, in so that I can do:

  sources:
    - repoURL: https://github.com/example/secrets
      targetRevision: main
      ref: source
    - helm:
        valueFiles:
        - $source/values.yaml
        - secrets+age-import-kubernetes://argocd/sops-age#key?$source/secrets.yaml
      repoURL: https://github.com/example/chart
      targetRevision: main
      path: ./

This would also help to work around the limitations expressed in https://github.com/jkroepke/helm-secrets/wiki/ArgoCD-Integration#external-chart-and-local-values

Would such behaviour be welcomed by the maintainers here?

Environment

N/A

Additional information

No response

Acceptance Criteria

No response

@almereyda almereyda added the enhancement New feature or request label Jan 12, 2023
@jkroepke
Copy link
Owner

See #316

@almereyda
Copy link
Contributor Author

🙈 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants