Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Hold Mission Duration conflict? #282

Open
OzanKurt opened this issue Jan 26, 2017 · 5 comments
Open

Hold Mission Duration conflict? #282

OzanKurt opened this issue Jan 26, 2017 · 5 comments

Comments

@OzanKurt
Copy link
Contributor

https://github.com/jkroepke/2Moons/blob/master/includes/pages/game/ShowFleetStep3Page.class.php#L399

I think the line should be so:

$fleetEndTime		= $fleetStartTime + $duration;

Any idea?

@jkroepke
Copy link
Owner

No, because EndTime is starttime + duration + holdtime + duration

@onomato93
Copy link

jkroepke, i think that its wrong, because when you send fleet on hold mission, (from 1 planet to 2 planet u have 1 hour), and fleet came on target planet, wait 5-10min, after that turn around your fleet, fleet should back in 1hour, but your fleet need 1h + 5-10min (time of hold). Its wrong, because your fleet should have the same time of arriving.

@OzanKurt
Copy link
Contributor Author

OzanKurt commented Feb 9, 2017

My reason for creating this issue was that the fleets having wrong arrival times.

For example: When I send a mission with 1 hour delay to a 15 minute planet.

it goes in 1:15 and comes back in 1:15.

In total 2:30. Should have been 1:30.

@onomato93
Copy link

but what i said is bad calculation too, because when you send fleet on holding mission, and flying duration is 1hour, and holding should been 20min, so when you turn back your fleet after 10min of holding, your time of back to planet should be again 1hour, but now is 1h + 10min. Have you any idea how to change it? I have no idea how to fix it, should be something like
if you turn back your fleet from holding (1h time of flying + 10min/20min of holding) your time should be again 1h. But if you change fleetEndTime, you broke holding time ;x

@jkroepke
Copy link
Owner

I will check this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants