unversioned dependency problem on locked dependencies project

[atilafassina]

Hello!

I might a problem using svg-sprite with grunt-svg-sprite when locking dependencies with npm shrinkwrap

on package.json, line 38 there's defined lodash as a dependency without version

"lodash": "lodash/lodash",

On grunt-svg-sprite dependencies, it generated with a git+https path, that would download any version, as far as I understand... possibly breaking the plugin if any major changes happen.

 "lodash": "git+https://github.com/lodash/lodash",

And, after locking dependencies with shrinkwrap it generates a relative path that's not working when I'm testing on different environments.

"from": "../../../../../../../var/folders/9f/39z7bx0s7sjgx9bqf1yqdjmh0000gn/T/npm-36893-3e27cd04/1421851729890-0.2797100490424782/ef3f0a0bb9f032d2eb3559fe9bcb5f49668c6f5f",

Does this all makes sense to you?
If so, I imagine the simplest solution would be to determine a version for lodash here, right?

[jkphl]

Hi @atilafassina,

thanks for your report. First of all, I have to say that I have no clue of shrinkwrap at all and I didn't test it during development.

Furthermore, when I was writing svg-sprite at around christmas, lodash was available in version 2.41, but I was relying on functionality that would be introduced with the upcoming v3.0, so I had to use the unversioned dependency to enforce the use of the latest sources from GitHub.

I just realized that the v3.0 of lodash is available since monday, so I'll happily go and update my dependency as soon as possible. I'll push out another release probably tonight or tomorrow.

Cheers,
Joschi

[atilafassina]

wow! Thanks a lot, @jkphl
That's probably gonna do the trick!!

After your commit, I'll test again and post the feedback here...

[jkphl]

You're welcome. Well, it looks like there's no official v3.0 NPM package yet. Will need to wait for that one. Stay tuned. ;)

[atilafassina]

👍 ok!
I'll keep an eye on that as well.

[jkphl]

Seems we'll have to wait until next Monday: https://twitter.com/jdalton/status/558308326862098432

[atilafassina]

Yeah... took some while more,
but it's released =)

[jkphl]

Thanks for the heads up. Will try to push out another release tonight! :)

[atilafassina]

👍 thanks a lot!

[jkphl]

The new release is out — hope this works for you now! :)

[atilafassina]

It did the trick! 🎉
Thanks a lot @jkphl

[jkphl]

You're welcome! Thanks for the feedback. :)