Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different size icons not being handled correctly #6

Open
pfiaux opened this issue Jul 25, 2014 · 5 comments
Open

Different size icons not being handled correctly #6

pfiaux opened this issue Jul 25, 2014 · 5 comments

Comments

@pfiaux
Copy link

pfiaux commented Jul 25, 2014

I tried generating a sprite sheet with a set of icons that have different sizes. This worked correctly on the online version of iconizr (they all get scaled down to the specified size).
In the node version the generated spritesheet was messed up in different ways:

  • The large ones scaled to the size defined.
  • The small ones scaled with a similar factor as the large ones rendering them really small.
  • The offsets generated in the sprite sheet and the less/css were inconsistent. For 32px there was offsets of 8px or even odd numbers like 17px.
  • Possibly as a side effect of the issues above the png sprite sheet generated all blank (but it has the correct size).

Is there a way to handle different sizes or is this a limitation?

@jkphl
Copy link
Owner

jkphl commented Jul 25, 2014

Hi @pfiaux,

thanks for report. I'd like to ask you to provide all the files involved as well (SVG sources, generated SVG sprite and PNG sprite). Please send them to joschi [at] kuphal [dot] net — thanks!

Also, please note that the online version at iconizr.com is based on the original PHP version and quite outdated at the moment (the Node version has far more features and options to consider).

Unfortunately, due to limited resources, I won't be able to work on your request in the next couple of days, so please don't expect me to be too fast! Sorry for that.

Cheers,
Joschi

@pfiaux
Copy link
Author

pfiaux commented Aug 6, 2014

I thought the site might be running the PHP version, since i noticed that was indeed more options in node. This is why i'm confused that it behaves differently on the same icon set. Files on the way.

@Red-nothing
Copy link

@jkphl did you find time to have a look at the issue already?

@jkphl
Copy link
Owner

jkphl commented Aug 25, 2014

@Red-nothing Sorry, no, not yet! :( I'm so totally overloaded at the moment that there is no time for working on side projects right now. Thanks for your patience!

@jkphl
Copy link
Owner

jkphl commented Jan 2, 2015

Hi @pfiaux & @Red-nothing,

just wanted to let you know that I didn't forget your issue! I'm going to start a rewrite of iconizr during the next days and will ensure that your assets render correctly in the new version!

Cheers & happy new year,
Joschi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants