Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Healthcheck #3

Open
lippertmarkus opened this issue Apr 10, 2018 · 3 comments
Open

[Feature Request] Healthcheck #3

lippertmarkus opened this issue Apr 10, 2018 · 3 comments

Comments

@lippertmarkus
Copy link

I really like your library and I would love to have a healthcheck feature builtin. Many applications need some time until they're fully started and often the DNS entry is updated too early as soon as a new application instance is started.

It would be great to have an option to only add hosts to the DNS cache if an HTTP healthcheck was successful. Would this be possible?

@jkeys089
Copy link
Owner

@lippertmarkus that definitely would be a nice feature. I'll leave this issue open in case anyone wants to commit some time to adding that feature in the future.

@mauricioabreu
Copy link

@lippertmarkus I know it is late but what would happen if health check determines the server is not OK?

@lippertmarkus
Copy link
Author

@mauricioabreu Something like this would have been my idea: If the healthcheck fails the domain shouldn't be added to the cache or be removed if it's already in there. If that's the case the lookup would fail and one can react to that accordingly within the balancer_by_lua_block.

But to be honest, I currently don't require that feature. But if that's helpful for you or for anyone else then go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants