-
Notifications
You must be signed in to change notification settings - Fork 30
Add Azure KeyVault integration #24
Comments
How to get started with this, if I wanted to help? I have no Go experience, so I would prefer some guidance as to where to start and how you see a design for this? |
Hey @clausndk - things have changed a little since I first proposed this issue. As the TLS config is pulled straight from the [serviceFabric.tls]
cert = "certs/servicefabric.crt"
key = "certs/servicefabric.key"
insecureskipverify = true You could use a SetupEntryPoint script that pulls the Azure credentials it needs to talk to Key Vault from environment variables and then grabs the certificates stored as base64encoded Key Vault secrets, decodes it and then injects them into the Hope that makes sense - I'll have a think if there's a better option. @lawrencegripper thoughts? |
Yeah this makes sense for me, unless we can find a way to roll this up into traefik but I'd expect the scope of the changes to be too large |
I have opened a PR which solves this (for windows only as I don't have Linux environment right now) |
Has there been progress made on this feature, or is it still up for grabs? |
hi @paul-mcgrath, we now link on the main README to @RamjotSingh's work available at the following repo: https://github.com/jjcollinge/traefik-on-service-fabric#multi-environment-support-and-automated-management-of-certificates. This works for Windows only, we haven't added anything additional on the Linux side. |
Hey that's fantastic, thank you! This is exactly what we were looking to solve right now. Very much appreciated 👍 |
@askw @flmader
The text was updated successfully, but these errors were encountered: