From 2d17a2b408a24de4b3ea70a00fd15302586b7adb Mon Sep 17 00:00:00 2001 From: Austin Seipp Date: Thu, 8 Aug 2024 19:27:13 -0500 Subject: [PATCH] github: try building on `macos-13` (x86) We all noticed that x86 macOS binaries are no longer being provided on release, due to `macos-11` runners going the way of the Dodo a while back. Nobody alterted us to this, funny enough. After some quick discussion, we concluded some things: - x86 macOS runners are likely oversubscribed, and hurt CI latency badly - `macos-12` is also deprecated; `macos-13` is the best x86 runner available - GitHub probably isn't going to expand macOS runner capacity; `macos-13` will one day go away - Some people are still using `jj` on Intel Macs. We didn't get alerted because they do their own builds for now, but may not always do that. - We can just try to build on `macos-13` and make it optional for merges. So that's what this does. It might be mergeable outright, but we can also use it to measure build latency impacts. Signed-off-by: Austin Seipp --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6081bb80083..49e673b5aeb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,8 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-14, windows-latest] + # macos-13 is x86; macos-14 is ARM + os: [ubuntu-latest, macos-13, macos-14, windows-latest] cargo_flags: [""] include: - os: ubuntu-latest