Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchable select elements #1147

Open
epuluikis opened this issue Nov 16, 2024 · 3 comments
Open

Searchable select elements #1147

epuluikis opened this issue Nov 16, 2024 · 3 comments
Assignees

Comments

@epuluikis
Copy link

Summary

The current implementation of select elements doesn't support search functionality. For teams with a large number of sources, it becomes time-consuming to find the desired option. Adding a search to select elements would dramatically improve UX.

As far as I'm aware, it should only require adding a showSearch attribute to the select element.

I could make a PR if the scope is provided for which selects to enable search (if not for all).

System configuration and versions

Jitsu Next - console

@vklimontovich
Copy link
Contributor

We'd gladly accept PR like this! Though I'm not sure I about which select you're taking - we have multiple. Would you mind attaching a screenshot?

@epuluikis
Copy link
Author

I primarily use the Site select on the Live Events page. However, this issue also affects other selects, such as the Source select on the Create Connection page. Because of this, I’d need guidance on which selects should be made searchable.

@vklimontovich
Copy link
Contributor

Got it. I think it makes sense to make most selects searchable. It should be easy for most of them, since they are all based on antd's Select and it looks like you just need one prop to enable search. Let's start with just one to see how easy it is, and take it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants