Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quality) Do not set b:AS line in SDP for SVC codecs when codec selection API is used. #2567

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(quality) Do not set b:AS line in SDP for SVC codecs when codec selection API is used. #2567

merged 1 commit into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. fix(quality) Do not set b:AS line in SDP for SVC codecs when codec se… 

    …lection API is used.

This was needed in older versions since the browser didn't apply maxBitrates from RTCRtpEncoderParameters on the encoder. In the newer versions this seems to be no longer the case. Also, when the codec selection API is used, we no longer renegotiate locally so if we switched codec from AV1->VP9-VP9, the AV1 bitrate setting in the SDP will still be effective resulting in a lower send resolution because of b/w limitation.
    @jallamsetty1
    jallamsetty1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dc55c04 View commit details
    Browse the repository at this point in the history