Sdp overhaul #1234
Sdp overhaul #1234
Conversation
… corner cases/side effects to other flows. haven't touched ffox yet
|
Hi, thanks for your contribution! |
|
Jenkins, add to whitelist, please. |
|
The tests have failed: Hmm seems to be outdated. Will try again. |
|
this depends on jitsi/lib-jitsi-meet#338 |
…verted back to how it is currently on master)
| APP.UI.setAudioMuted(this.getMyUserId(), this.audioMuted); | ||
| }); | ||
| useAudioStream (newStream) { | ||
| room.replaceStream(localAudio, newStream) |
There was a problem hiding this comment.
I think now we are not returning anything anymore. Is this by mistake?
We should either return Promise either fix the documentation if we don't need the Promise anymore.
There was a problem hiding this comment.
fixed (returned the promise)
| * @returns {Promise} | ||
| */ | ||
| useVideoStream (newStream) { | ||
| room.replaceStream(localVideo, newStream) |
There was a problem hiding this comment.
I think now we are not returning anything anymore. Is this by mistake?
We should either return Promise either fix the documentation if we don't need the Promise anymore.
There was a problem hiding this comment.
fixed (returned the promise)
No description provided.