fix(local-recording) Don't use tab audio #12334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Oct 7, 2022
lang/main.json
Outdated
| @@ -625,7 +625,6 @@ | |||
| "no": "No", | |||
| "participant": "Participant", | |||
| "participantStats": "Participant Stats", | |||
| "selectTabTitle": "🎥 Please select this tab for recording", | |||
There was a problem hiding this comment.
Please leave this, curious people may still click around...
| @@ -219,23 +218,14 @@ const LocalRecordingManager: ILocalRecordingManager = { | |||
| permittedOrigins: [ '*' ] | |||
| }); | |||
| } | |||
|
|
|||
| const currentTitle = document.title; | |||
We have observed that participant audio is distant and garbled, so we added the tracks individually to the mixer. In addition, using tab audio prevents us from using preferCurrentTab due to: https://bugs.chromium.org/p/chromium/issues/detail?id=1317964 so losing audio effects but having better participant audio quality (in addition to better UX) is not a bad compromise.
saghul
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.