Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua 5.1 / LuaJIT support #5

Closed
rurounijones opened this issue May 6, 2018 · 6 comments
Closed

Lua 5.1 / LuaJIT support #5

rurounijones opened this issue May 6, 2018 · 6 comments

Comments

@rurounijones
Copy link

rurounijones commented May 6, 2018

Attempting to run the examples with Lua52, Lua51 and LuaJIT result in the examples hanging or crashing.

Is there any possibility of supporting lua51 release which will also add support for the popular and the very fast http://luajit.org/ lua implementation?

I am relatively new to the lua ecosystem so I am not sure how difficult this will be (although I am assuming it is not trivial amount of work given the number of dependencies etc.).

Based on martanne/vis#291 it looks like it could be possible to get LuaJit compatible with 5.2 although most applications of luaJit would probably not be using this patch.

@jinq0123
Copy link
Owner

jinq0123 commented May 7, 2018

It is easy to support Lua51 and LuaJIT. But I have no time to do this.

@rurounijones
Copy link
Author

rurounijones commented May 7, 2018

If you think it should be easy then I will have a look and see if I can make the changes. If you have any starting points / advice that would be useful. Thanks for the info.

[EDIT] In my newness to lua I was missing an obvious thing here in that the versions of lua are not ABI compatible so I believe that dlls compiled with the current build system are for 5.3 and won7t be usable from earlier versions. Step 1 is my figuring out how to actually compile with the correct version of lua.

@jinq0123
Copy link
Owner

jinq0123 commented May 8, 2018

I add a section TODO: Integrate into Unity in README.

@rurounijones
Copy link
Author

rurounijones commented May 17, 2018

Thanks for the information.

I will have a look but since I am completely new to lua and the ecosystem in general I am happy to sponsor this feature to $200 if anyone can do it to @jinq0123 satisfaction and get it merged.

Edit: I am using a different RPC system for the moment which does the job. I would be interested in sponsoring any work to get this working in 5.1 in an environment (Specifically the Mission Scripting Encironment of the game DigitalCombatSimulator) where the GRPC server is not the main event loop.

@subnetmarco
Copy link

Any updates?

@4mig4
Copy link

4mig4 commented Mar 3, 2021

Wondering the same

@rurounijones rurounijones closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants