Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't parse return a Result? #9

Open
Euregan opened this issue Aug 18, 2017 · 0 comments
Open

Shouldn't parse return a Result? #9

Euregan opened this issue Aug 18, 2017 · 0 comments

Comments

@Euregan
Copy link

Euregan commented Aug 18, 2017

Shouldn't parse return a Result rather than a List Node ? I was using the lib to write a Chrome extension that parsed the tab's DOM, and it just returns [] if the DOM is malformed, which could be handled more gracefully than an empty list check. That would also introduce the possibility of the parsing failing because of the DOM.
I understand though that this is a major breaking change :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant