Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Declaration is not a Processing Instruction #174

Open
davemevans opened this issue Aug 4, 2016 · 1 comment · May be fixed by #209
Open

XML Declaration is not a Processing Instruction #174

davemevans opened this issue Aug 4, 2016 · 1 comment · May be fixed by #209

Comments

@davemevans
Copy link

xmldom appears to interpret the XML Declaration (<?xml ?>) as a Processing Instruction and inserts a Node into the DOM with nodeType 7.

This is incorrect and there should be no reference to the XML declaration in the DOM - the XML Declaration is not a Processing Instruction.

Chrome and Firefox, for example, correctly returns the DOM without any reference to the XML Declaration.

davemevans referenced this issue in bbc/dash.js Aug 8, 2016
…presentation is far harder than expected - DashManifestModel methods starting with getAdaptation... doesn't mean it'll get an adaptation, and it generally expects things to have happened in e.g. DashAdapter or DashHandler that augment the default objects before it works... Also always calculates full list of segments for an ondemand stream.
@Holzhaus
Copy link

I can reproduce this. I'll see if I can come up with a patch.

Holzhaus added a commit to Holzhaus/xmldom that referenced this issue Jun 11, 2017
The XML declaration is not a processing instruction.

According to XML 1.0 (5th Edition), Section 2.6, the PI target names "xml",
"XML" and so on are reserved.

Production Rule 17 states:
> PITarget ::= Name - (('X' | 'x') ('M' | 'm') ('L' | 'l'))

This fixes jindw#174.
Holzhaus added a commit to Holzhaus/xmldom that referenced this issue Jun 11, 2017
The XML declaration is not a processing instruction.

According to XML 1.0 (5th Edition), Section 2.6, the PI target names "xml",
"XML" and so on are reserved.

Production Rule 17 states:
> PITarget ::= Name - (('X' | 'x') ('M' | 'm') ('L' | 'l'))

This fixes jindw#174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants