Unlink libtvm.so and libcuda.so in older TVM #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 8, 2020 09:22
This reverts commit de38c52.
yzhliu
reviewed
Jul 13, 2020
cmake/modules/CUDA.cmake
Outdated
| @@ -35,7 +35,9 @@ if(USE_CUDA) | |||
|
|
|||
| list(APPEND TVM_LINKER_LIBS ${CUDA_NVRTC_LIBRARY}) | |||
| list(APPEND TVM_RUNTIME_LINKER_LIBS ${CUDA_CUDART_LIBRARY}) | |||
| list(APPEND TVM_RUNTIME_LINKER_LIBS ${CUDA_CUDA_LIBRARY}) | |||
| if(CUDA_COMPILE_ONLY) | |||
| list(APPEND TVM_RUNTIME_LINKER_LIBS ${CUDA_CUDA_LIBRARY}) | |||
There was a problem hiding this comment.
does not seem to comply with "Build libtvm.so without libcuda.so"
|
|
||
| PackedFunc CUDAModuleNode::GetFunction( | ||
| const std::string& name, | ||
| const ObjectPtr<Object>& sptr_to_self) { | ||
| #ifdef CUDA_COMPILE_ONLY |
There was a problem hiding this comment.
this one actually complies with "Build libtvm.so without libcuda.so"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.