Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme #903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated readme #903

wants to merge 1 commit into from

Conversation

themantalope
Copy link

updated readme to show command for building docker image locally.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themantalope Thanks for your interest. Can the guidelines in our current doc not work for you? https://clip-as-service.jina.ai/user-guides/server/#build

@numb3r3
Copy link
Member

numb3r3 commented Apr 4, 2023

Ok, I see. You want to build CUDA image. May I ask you to add the building CLI in our document instead of README?

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #903 (ead4e60) into main (f4eed3b) will decrease coverage by 20.59%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
- Coverage   82.73%   62.14%   -20.59%     
===========================================
  Files          23       23               
  Lines        1564     1564               
===========================================
- Hits         1294      972      -322     
- Misses        270      592      +322     
Flag Coverage Δ
cas 62.14% <ø> (-20.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@themantalope
Copy link
Author

Hi @numb3r3

Yeah that's fine. I wanted to use it as an executor in a jina flow. The documentation wasn't clear that was the correct way to locally build for the flow use case.

@numb3r3
Copy link
Member

numb3r3 commented Apr 4, 2023

@themantalope For your purpose, you can directly use the containerized executor from the hub jinahub+docker://CLIPTorchEncoder (https://cloud.jina.ai/executor/gzpbl8jh):

jtype: Flow
executors:
  - uses: jinahub+docker://CLIPTorchEncoder

In the above example, the executor will be a docker container in a flow.

But you are right, the document is not clear and misleading. Thank you for pointing that out.

@themantalope
Copy link
Author

themantalope commented Apr 4, 2023

@numb3r3 the other reason why I wanted to build is because I needed to fork the code and add debug statements. Even on JINA_LOG_LEVEL=DEBUG I was getting errors from the indexer stating that a Doc.embedding was None. I was trying to figure out which piece of data it was etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants