Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] The examples of the migration guide are erroneous #1316

Closed
ghostd opened this issue Sep 2, 2024 · 1 comment · Fixed by #1318
Closed

[doc] The examples of the migration guide are erroneous #1316

ghostd opened this issue Sep 2, 2024 · 1 comment · Fixed by #1318
Labels
released This issue/pull request has been released.

Comments

@ghostd
Copy link

ghostd commented Sep 2, 2024

The migration guide contains examples with the old function getBufferAsync. In "v1", the new method seems to be getBuffer(which is still async)
@hipstersmoothie hipstersmoothie mentioned this issue Sep 2, 2024
Merged
@hipstersmoothie
Copy link
Collaborator

🚀 Issue was released in v1.1.2 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix incorrect usage in docs jimp-dev/jimp
2 participants
@ghostd @hipstersmoothie