Streamsaver does not clean up iframes

[acuntex]

When using StreamSaver.js in a long living SPA, you see that StreamSaver.js does not cleanup the iframes, thus poluting the DOM.

Repro: Just download and look at the dom :-)

[jimmywarting]

I tried to clean it up before but for some reason it didn't work so well,
Don't remember what it was exactly, in some edge cases the download never started if the iframe where removed before any bytes have been written to the iframe - so it would just be safer to leave it there, all it is is an empty iframe - not consuming any dom, js or css

backlog: #94

[acuntex]

Just an idea: Can we somehow tag the iframes with a custom attribute and a timestamp? So that an application can identify these iframes and clean up "old" iframes.

I've noticed performance issues if there are more than 100 iframes. Not 100% sure if it's because of this but this is my best guess.

[jimmywarting]

sure, we could "tag" them with something. <iframe data-streamsaver> maybe?
otherwise another solution is to get them with src css-selector

$(iframe[src^="${streamSaver.mitm.replace(/mitm.*/, location.hostname)}"])

^ means startsWith

[acuntex]

Yes, but i would maybe also include a timestamp... just in case so that an automatic cleanup by the application does not kill the current download.

[jimmywarting]

fyi when native file system gets implemented, then we might not need iframes or service workers :)

[jimmywarting]

more than 100 iframes

why don't you zip everything?

[acuntex]

fyi when native file system gets implemented, then we might not need iframes or service workers :)

yay :-)

why don't you zip everything?

It's a timing issue. This would be only possible if all files would be present at the same time. In a long running application this might not be the case :-(