Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render preview can't write a comment when the PR is a forked repository #310

Closed
cansavvy opened this issue Nov 3, 2021 · 1 comment
Closed

Render preview can't write a comment when the PR is a forked repository #310

cansavvy opened this issue Nov 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cansavvy
Copy link
Collaborator

cansavvy commented Nov 3, 2021

The preview builds properly, but it just doesn't have permissions to write the comment with the links. There's a way around this that involves writing a github actions that triggers with pull_request_target: synchronize but I think this is a job for another day. The payoff is not worth how much its going to further obfuscate the github actions setup

Originally posted by @cansavvy in #299 (comment)
@cansavvy cansavvy added the bug Something isn't working label Nov 3, 2021
@cansavvy
Copy link
Collaborator Author

I believe this is fixed. But if we see it happen again we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cansavvy