Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback masthead image #6

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

godbyk
Copy link
Contributor

@godbyk godbyk commented Aug 31, 2018

Use default hero image from config.toml if no page-specific image is specified.

@godbyk
Copy link
Contributor Author

godbyk commented Aug 31, 2018

I'm a complete newb to both Hugo, this theme, and half the languages used. So if I've screwed something up or misunderstood some underlying concept, please let me know. Thanks!

@ndarwincorn
Copy link

@godbyk - I came here just now to submit my own PRs that mirror #5 and #6, and at about the same amount of familiarity, and your solution here is much more elegant than mine.

@godbyk
Copy link
Contributor Author

godbyk commented Aug 31, 2018

@ndarwincorn Thanks, it's nice to know I'm not totally off base, at least!

@jhu247
Copy link
Owner

jhu247 commented Sep 3, 2018

Hi @godbyk - unfortunately this won't work in Hugo's theme site without absURL, more info here.

@godbyk
Copy link
Contributor Author

godbyk commented Sep 3, 2018

@jhu247 Sorry, I had removed absURL because of this issue. Using the workaround posted there, I was able to restore absURL and still have a fallback/global hero image.

Please take a look at the updated code. (I'm happy to squash the commits if you prefer, too.)

@jhu247
Copy link
Owner

jhu247 commented Sep 4, 2018

Looks great! Verified on my end. Please squash your commits and I'll merge 👍

@godbyk
Copy link
Contributor Author

godbyk commented Sep 4, 2018

@jhu247 Squashed! Should be ready to merge now. Thanks!

@jhu247 jhu247 merged commit c5c01e6 into jhu247:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants