-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration Testing] Add cypress to the main generator #11961
Comments
cc @nassimerrahoui and @adilabed as they already did it for JHipster Control Center, and nearly finished the work from @clementdessoude in Vue.js blueprint Then, @sendilkumarn, I would suggest to add Cypress for v6 if possible AND remove Protractor in v7 |
@pascalgrimaud I like this idea. Can we start working on this in a branch (likely this one) or any other (instead of duplicating work) ? WDYT? |
I am in favor of concentrating our efforts in this branch https://github.com/sendilkumarn/generator-jhipster/tree/feat/add-cypress, instead of duplicating work. |
Yes, it's sounds good to me ! 👍 |
As discussed with other members, there is 3 solutions :
|
I like the idea of targetting specific attributes for selecting elements. In the end game, it will:
|
I am all in for targeting specific attributes for selecting elements. But it will be a pain to maintain it across blueprints and an unwanted dependency to carry forward. I am all in if we can find a way around it. But yeah the main generator should have only one cypress test suite. Let us refactor it. I will create a project in that repo, feel free to pick whatever you like and we will ship it 👍 Looking forward to it already. [Edit] The project is available here |
Adding a $100 bug bounty as proposed by @MathieuAA on #11805 |
hi @sendilkumarn WDYT? Have you any idea of what is in to do? I have checked this branch https://github.com/sendilkumarn/generator-jhipster/tree/feat/add-cypress and this project https://github.com/sendilkumarn/generator-jhipster/projects/1 regards, EDIT:
Does it seems a good strategy ? |
Finally we move the cypress current work to my JHipster fork because we were not able to rebase from last master version. A draft PR has been open here. We need to:
|
increasing the bounty as it's a lot of work to achieve it |
It's a lot lot lot of work to achieve this, and it was a team work.
@avdev4j : it was during your full time contribution to JHipster Hope you're ok with this. As the work is achieved, let's close this. |
Let's do that! Congrats everyone |
@nassimerrahoui @adilabed : approved |
@qmonmert : approved |
Are there any examples available of how to use cypress with JWT Token? I can't pass through jhi related stuff because something really cheesy is customized there:
First of all I have noticed that instead of local storage session storage is used. But I really don't have any ideas why code above is not working, cause I'm setting id_token exactly as if it will be normal login https://stackoverflow.com/questions/64714984/jhipster-programatically-login-using-cypress-and-jwt |
Overview of the feature request
Cypress is awesome, it is debuggable and it is easy and framework agnostic.
Motivation for or Use Case
Protractor is flaky for react, while there were multiple attempts to fix them. I think it is a high time to move away from the protractor and start using
Cypress
.Related issues or PR
#11923 #11916 #11814 and others
There are a lot of discussions happened before especially this one :: jhipster/jhipster-vuejs#399
I have also started the migration in this branch, let us merge both into the main generator and start using Cypress.
The text was updated successfully, but these errors were encountered: