Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs not working in embedded markdown files #31

Closed
wkande opened this issue Oct 8, 2020 · 1 comment
Closed

Tabs not working in embedded markdown files #31

wkande opened this issue Oct 8, 2020 · 1 comment

Comments

@wkande
Copy link

wkande commented Oct 8, 2020

With docsify 4.6 it is now possible to embed any type of file, including a markdown file.

If a tab-set is added to the parent file it works fine. However a tab-set added to an embedded file does not render.

tabs-main.md

# tabs-main.md

<!-- tabs:start -->

#### ** English **

Hello!

<!-- tabs:end -->

[filename](tabs-include.md ':include')

tabs-include.md

# tabs-include.md

<!-- tabs:start -->

#### ** English **

Hello!

<!-- tabs:end -->

I have included a screen shot of the results I get.

Screen Shot 2020-10-08 at 3 30 53 PM

@jhildenbiddle
Copy link
Owner

jhildenbiddle commented Nov 5, 2020

Thanks for the suggestion, @wkande.

Unfortunately, this is a limitation of docsify's plugin system and not something that docsify-tabs can easily resolve. The short explanation is that docsify's plugin system functions at the page level, so there is no "hook" to leverage for processing content that is loaded via an embed.

If you're interested in seeing this feature added to docsify, I recommend creating a docsify issue and referencing this issue to serve as an example.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants