Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional diamond compatibility #56

Merged
merged 9 commits into from
Oct 16, 2017
Merged

Additional diamond compatibility #56

merged 9 commits into from
Oct 16, 2017

Conversation

caleb-easterly
Copy link
Contributor

@caleb-easterly caleb-easterly commented Jul 31, 2017

This fixes an option clash with JJ's diamond database option (-d), which was also used for specific reference databases (e.g., homNOG). Also, I added try-catch exception handling to the diamond call, to expose diamond-specific errors when the call fails - I had some trouble figuring out where errors were.

This builds upon JJ's work to make fewer paths hard-coded.

I also updated the diamond version to the most recent (0.9.9)

jj-umn and others added 6 commits April 28, 2017 15:44
I am suggesting a few changes that I think may be useful for installing
eggnog-mapper via bioconda and using it in a galaxy installation.  This
allows the data dir to be independent of the installation directory.
Also allows a path for the diamond db.
return value for get_db_present(level) should be a boolean
@caleb-easterly
Copy link
Contributor Author

caleb-easterly commented Jul 31, 2017

Also, this is a small data directory, hopefully something like what you and @jj-umn were talking about in #44.

Using the capability that JJ added to specify the data directory at runtime, the single sequence in nlim_fragment.fasta can be annotated. For some reason, diamond isn't giving annotations, which I can't figure out.

Although still big (~352MB), it is at least more downloadable for unit testing and Galaxy integration testing. It seems like further reduction in size would have to come from manually re-creating the hmmpressed files, which are the only truly big thing.

Any comments/PRs on what else could be useful in a small database would be useful. Or suggestions about how to pare down the HMM.

@jhcepas
Copy link
Member

jhcepas commented Aug 8, 2017

thanks for this. I need time to review all changes, but I'll let you know soon.

@jhcepas jhcepas merged commit 9f12b50 into eggnogdb:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants