Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data dir to be independent of install dir #44

Merged
merged 4 commits into from
Oct 16, 2017

Conversation

jj-umn
Copy link
Contributor

@jj-umn jj-umn commented Apr 28, 2017

I am suggesting a few changes that I think may be useful for installing
eggnog-mapper via bioconda and using it in a galaxy installation. This
allows the data dir to be independent of the installation directory.
Also allows a path for the diamond db.

I am suggesting a few changes that I think may be useful for installing
eggnog-mapper via bioconda and using it in a galaxy installation.  This
allows the data dir to be independent of the installation directory.
Also allows a path for the diamond db.
@jhcepas
Copy link
Member

jhcepas commented May 2, 2017

looks nice! thanks @jj-umn
I will review and integrate as soon as posible.

@jj-umn
Copy link
Contributor Author

jj-umn commented May 2, 2017

@jhcepas Thanks. When making a galaxy tool, we try to have a minuscule amount of data in the tool test-data directory to verify the tool is working. Being able to specify paths allows use of tiny diamond db or hmm db from that test-data dir.
I'll also start looking at creating a conda recipe for installing eggnog-mapper to put in: https://github.com/bioconda/bioconda-recipes

@jhcepas
Copy link
Member

jhcepas commented May 2, 2017

that sounds great. Would you be willing to share that testing code and data?
Unittests are still in the TODO list here...

@jj-umn
Copy link
Contributor Author

jj-umn commented May 3, 2017

@jhcepas If I can figure out some minimal testing data, I'll be happy to share.

@jhcepas jhcepas merged commit 3a4f994 into eggnogdb:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants