Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on more than strings #1

Closed
tamird opened this issue Feb 8, 2016 · 3 comments
Closed

work on more than strings #1

tamird opened this issue Feb 8, 2016 · 3 comments

Comments

@tamird
Copy link

tamird commented Feb 8, 2016

This would be useful in cockroachdb/cockroach if it could also detect duplicate integers. In particular, we want to use constants for time.Durations in our tests - it'd be nice if this tool provided that check.

@jgautheron
Copy link
Owner

You can now use -numbers. It searches for duplicate integers and floats.

@tamird
Copy link
Author

tamird commented Mar 1, 2016

Heh, this is sadly too much of a blunt instrument - it picks up very small numbers that aren't worth extracting like if len(args) == 1 {....}. Perhaps a threshold?

@jgautheron
Copy link
Owner

Just implemented -min and -max, let me know if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants