Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attribute conflict validation for 'cves' and 'vulnerabilities' #151

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

alexhung
Copy link
Member

Also remove 'Computed' attribute for 'cves'. Practitioners need to set "any" if 'vulnerabilities' is also set to 'any' to avoid state drift.

Update documentation for the same.

Closed #148

Also remove 'Computed' attribute for 'cves'. Practitioners need to set "any" if 'vulnerabilities' is also set to 'any' to avoid state drift.

Update documentation for the same.
@alexhung alexhung added the bug Something isn't working label Nov 29, 2023
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
@alexhung
@jfrogsolutioncicd
@jfrog Pipelines Step
JFrog Pipelines Step seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@alexhung alexhung marked this pull request as ready for review November 29, 2023 22:38
@alexhung alexhung requested a review from danielmkn as a code owner November 29, 2023 22:38
@alexhung
Copy link
Member Author

@danielmkn Tests pass acceptance tests now. It's kinda odd...

@alexhung alexhung merged commit 982e4cd into master Nov 29, 2023
2 of 3 checks passed
@alexhung alexhung deleted the GH-148-fix-ignore-rule-attributes-conflict branch November 29, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xray_ignore_rule error out when cves and vulnerabilities
3 participants