Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve download scripts #2202

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Improve download scripts #2202

merged 1 commit into from
Sep 13, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 13, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@yahavi yahavi added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Sep 13, 2023
@yahavi yahavi self-assigned this Sep 13, 2023
@yahavi yahavi requested a review from sverdlov93 September 13, 2023 09:17
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 13, 2023
@yahavi yahavi requested a review from RobiNino September 13, 2023 10:54
sverdlov93
sverdlov93 reviewed Sep 13, 2023
View reviewed changes
build/getcli/jf.sh
@@ -13,11 +12,11 @@ else
echo "Downloading the latest version of JFrog CLI..."
fi

if $(echo "${OSTYPE}" | grep -q msys); then
if echo "${OSTYPE}" | grep -q msys; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked in multiple OSs - MacOS, Ubuntu, Debian, Alpine, Fedora.
Also, the automatic tests check for - MacOS, Ubuntu, Windows.

@yahavi yahavi merged commit 0c805fb into jfrog:dev Sep 13, 2023
57 of 120 checks passed
@yahavi yahavi deleted the fix-scripts branch September 13, 2023 12:15
@chenrui333 chenrui333 mentioned this pull request Sep 13, 2023
Merged
@kvalkhof75 kvalkhof75 mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @sverdlov93