Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sarif output driver issues and Xray Sca locations #968

Merged
merged 34 commits into from
Oct 3, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Sep 19, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fixes some discovered issues that make the Sarif output not pass validations:

  • Fix the returned path at Xray SCA results to show the actual full path or not at all.

  • Add Information Uri for missing Advance security scanners

  • Set default version for Advance scanners if it does not exist or is not valid to the AnalyzerManager version.

  • Move test funcs from sarifutils to a separate file

  • Fix bug in setting the file names of locations

  • Remove 'markdown' flag and make the Xray run generation fit for all users

@attiasas attiasas marked this pull request as ready for review September 19, 2023 16:04
@attiasas attiasas requested a review from sverdlov93 September 19, 2023 16:15
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
utils/coreutils/techutils.go Outdated Show resolved Hide resolved
utils/coreutils/techutils.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
xray/utils/resultwriter.go Outdated Show resolved Hide resolved
@attiasas attiasas temporarily deployed to frogbot October 3, 2023 08:17 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023


@attiasas attiasas merged commit c17c0f5 into jfrog:dev Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants