Third party dependencies contextual analysis for npm #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
reviewed
Sep 13, 2023
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
…clude_node_modules_applicabilities
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
sverdlov93
reviewed
Sep 13, 2023
| @@ -19,8 +19,12 @@ import ( | |||
| "gopkg.in/yaml.v3" | |||
| ) | |||
|
|
|||
| const ( | |||
| NodeModulesPattern = "**/*node_modules*/**" | |||
There was a problem hiding this comment.
Suggested change
| NodeModulesPattern = "**/*node_modules*/**" | |
| nodeModulesPattern = "**/*node_modules*/**" |
There was a problem hiding this comment.
been used from applicablitymanager.go so has to be public
sverdlov93
reviewed
Sep 13, 2023
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the new flag of the CLI :
third-party-contextual-analysisThe applicability scanner will run on the environments folders as well. ( node_modules etc...)
In this case we will need to exclude the reported applicabilities which originated from the impacted source package.
For example:
protobufjsCVE applicability was found:applicability location is inside node_modules/protobufjs -> disqualify
Other use case:
applicability location is inside node_modules/someOtherDep -> valid.