Extend ParseIncomingWebhook function to handle tag related events #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilc-pro
approved these changes
Apr 25, 2023
pavelmemory
changed the title
yahavi
suggested changes
Apr 27, 2023
| @@ -228,14 +266,27 @@ type bitbucketPush struct { | |||
| } | |||
|
|
|||
| type bitbucketChange struct { | |||
There was a problem hiding this comment.
Looks like the "New" and the "Old" can be exported to a new struct to remove duplications.
I suggest doing the following:
- Create a new struct "bitbucketResourceChange" (or something equivalent) with Name, Target, Type, and Message
- Old and New will be of type bitbucketResourceChange
| @@ -262,6 +265,79 @@ func TestBitbucketServerParseIncomingPrWebhook(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
| func TestBitbucketServer_parseIncomingWebhookTagEvents(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func TestBitbucketServer_parseIncomingWebhookTagEvents(t *testing.T) { | |
| func TestBitbucketServerParseIncomingWebhookTagEvents(t *testing.T) { |
| @@ -328,6 +330,78 @@ func TestGithubParseIncomingPrWebhook(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestGitHub_parseIncomingWebhookTagEvents(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func TestGitHub_parseIncomingWebhookTagEvents(t *testing.T) { | |
| func TestGitHubParseIncomingWebhookTagEvents(t *testing.T) { |
The general WebhookInfo is extended and now encapsulates information about the tag event. The webhook parsing logic is able to process tag event and return valid WebhookInfo for the GitLab VCS.
The general WebhookInfo is extended and now encapsulates information about the tag event. The webhook parsing logic is able to process tag event and return valid WebhookInfo for the Bitbucket Server VCS.
The general WebhookInfo is extended and now encapsulates information about the tag event. The webhook parsing logic is able to process tag event and return valid WebhookInfo for the Bitbucket Cloud VCS.
The general WebhookInfo is extended and now encapsulates information about the tag event. The webhook parsing logic is able to process tag event and return valid WebhookInfo for the GitHub VCS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go fmt ./...for formatting the code before submitting the pull request.The tag creation and removal webhook events now can be parsed by the
ParseIncomingWebhook()function. The information about the tag is stored in the newTagfield of theWebhookInfotype. Also, the two new events added:TagPushedandTagRemovedto represent each of these operations.