Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Gradle versions even if strerr is not empty #198

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Sep 27, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Fix the following error:

17:57:27 [Error] unexpected error occurred during attempt to get the Gradle version: Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

In specific Java versions, if you set the JAVA_TOOL_OPTIONS environment variable, starting a Java process will result in the message "Picked up JAVA_TOOL_OPTIONS" being shown on the standard error (stderr). This pull request alters the way Gradle version is determined, enabling it to capture output from the standard output (stdout) even when there is text on the standard error (stderr).

@yahavi yahavi assigned sverdlov93 and yahavi and unassigned sverdlov93 Sep 27, 2023
@yahavi yahavi requested a review from sverdlov93 September 27, 2023 13:25
@yahavi yahavi added the bug Something isn't working label Sep 27, 2023
@yahavi yahavi merged commit 8938b21 into jfrog:dev Sep 27, 2023
13 of 14 checks passed
@yahavi yahavi deleted the gradle-version branch September 27, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants