You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed a general lack of consistency regarding documentation, code and exceptions.
Particularly, I noticed two examples:
in AbstractRenderer
the method setDefaultItemLabelFont(Font font, boolean notify)
is missing a null check for the parameter font like the method setDefaultItemLabelFont(Font font) has, and the doc of both suggests.
in CustomPieURLGenerator
the method getURLCount(int plotIndex) needs a check of the boundaries for the provided index, similar to what getURL(Comparable<?> key, int plotIndex) has. Instead, the exception that may arise from calling_urlMaps.get(plotIndex)_ could be documented.
I noticed a general lack of consistency regarding documentation, code and exceptions.
Particularly, I noticed two examples:
the method setDefaultItemLabelFont(Font font, boolean notify)
is missing a null check for the parameter font like the method setDefaultItemLabelFont(Font font) has, and the doc of both suggests.
proposed code:
the method getURLCount(int plotIndex) needs a check of the boundaries for the provided index, similar to what getURL(Comparable<?> key, int plotIndex) has. Instead, the exception that may arise from calling_urlMaps.get(plotIndex)_ could be documented.
proposed code:
The text was updated successfully, but these errors were encountered: