Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue #1

Open
umarmw opened this issue Jul 2, 2019 · 2 comments
Open

Dependency issue #1

umarmw opened this issue Jul 2, 2019 · 2 comments

Comments

@umarmw
Copy link

umarmw commented Jul 2, 2019

Hello,

It seems the tutorial is out of date. I tried to execute it directly on the "react-helix" folder but got this error:

Failed to compile

./node_modules/history/esm/history.js
Module not found: Can't resolve '@babel/runtime/helpers/esm/extends' in 'C:\inetpub\wwwroot\Sitecore\Experimental\poc\jss-app-templates\react-helix\node_modules\history\esm'

Any idea?

@jflheureux
Copy link
Owner

Indeed, this repo was created with JSS Technical Preview 4 (TP4). You could compare the react-helix folder with the latest official React sample ( https://github.com/Sitecore/jss/tree/master/samples/react ) and merge what needs to be merged. Then you can create a JSS app from a template stored in a local folder of your hard drive with a special command line argument.

@ksbhatt1107
Copy link

I resolved this issue by commenting the module reference in history.js file at two places -

  1. node_modules\react-router\node_modules\history\esm\history.js
  2. node_modules\react-router-dom\node_modules\history\esm\history.js

Commented first line - "import _extends from '@babel/runtime/helpers/esm/extends';" in above files.

My app started working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants