Definition order matters with @JsonProperty

[sp00x]

I noticed this the scratch-head-a-lot way:

import { serialize, deserialize, JsonProperty } from 'json-typescript-mapper';

class City
{
    @JsonProperty({ clazz: Farm })
    farms: Farm[] = void 0;
}

class Farm 
{
    name: string = void 0;
    
    @JsonProperty({ clazz: Animal })
    animals: Animal[] = void 0;
}

class Animal
{
    type: string = void 0;
    name: string = void 0;
}


let json = {
    farms: [
        {
            name: 'farm 1',
            animals: [
                { type: 'cow', name: 'Cow 1' },
                { type: 'cow', name: 'Cow 2' },
            ]
        }
    ]
}

console.dir(deserialize(City, json), { depth: null });

result:

City {
  farms:
   [ { name: 'farm 1',
       animals:
        [ { type: 'cow', name: 'Cow 1' },
          { type: 'cow', name: 'Cow 2' } ] } ] }

Switch the order so the classes are defined at the time they're referred from @JsonProperty:

import { serialize, deserialize, JsonProperty } from 'json-typescript-mapper';

class Animal
{
    type: string = void 0;
    name: string = void 0;
}

class Farm 
{
    name: string = void 0;
    
    @JsonProperty({ clazz: Animal })
    animals: Animal[] = void 0;
}

class City
{
    @JsonProperty({ clazz: Farm })
    farms: Farm[] = void 0;
}

let json = {
    farms: [
        {
            name: 'farm 1',
            animals: [
                { type: 'cow', name: 'Cow 1' },
                { type: 'cow', name: 'Cow 2' },
            ]
        }
    ]
}

console.dir(deserialize(City, json), { depth: null });

result:

City {
  farms:
   [ Farm {
       name: 'farm 1',
       animals:
        [ Animal { type: 'cow', name: 'Cow 1' },
          Animal { type: 'cow', name: 'Cow 2' } ] } ] }

Might be worth mentioning or looking into.. I spent an hour here before I noticed..

[bassrock]

@sp00x But what if the classes are in separate files?

[sp00x]

@bassrock I'm guessing it would partially solve itself automatically then as you'd be import'ing them at the top of the file, i.e. before the references.