#10226 fix buffer leak in consumeAvailable() when HttpStream.consumeA…

…vailable() leaves unconsumed content Signed-off-by: Ludovic Orban <[email protected]>
jetty · Aug 30, 2023 · 58a5499 · 58a5499
1 parent 87430f9
commit 58a5499
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java b/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpConnection.java
@@ -1145,11 +1145,18 @@ public Throwable consumeAvailable()
         {
             Throwable result = HttpStream.consumeAvailable(this, getHttpConfiguration());
             if (result != null)
+            {
                 _generator.setPersistent(false);
-            // If the parser is not at the end, an idle timeout occurred and nothing
-            // is ever going to release the buffer -> release it here.
-            if (!_parser.isState(HttpParser.State.END))
-                releaseRequestBuffer();
+                // If HttpStream.consumeAvailable() returns an error, there may be unconsumed content left,
+                // so we must make sure the buffer is released and that the next chunk indicates the end of the stream.
+                if (_retainableByteBuffer != null)
+                {
+                    _retainableByteBuffer.release();
+                    _retainableByteBuffer = null;
+                }
+                if (_chunk == null)
+                    _chunk = Content.Chunk.from(result, true);
+            }
             return result;
         }