Skip to content

Commit

Permalink
Fix #9169 refine idle timeout and failure
Browse files Browse the repository at this point in the history
Only fail request callback if a failure has not been otherwise notified.
Slight optimization for failing idle timeouts by avoiding double lock.
Always create a failure if failing the callback.
  • Loading branch information
gregw committed Aug 29, 2023
1 parent 5bf8241 commit 013ae3c
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ public Runnable onIdleTimeout(TimeoutException t)
{
if (onIdleTimeout.test(t))
{
// If the idle timeout listener(s) return true, then we call onFailure and any task it returns.
// If the idle timeout listener(s) return true, then we call onFailure and run any task it returns.
Runnable task = onFailure(t);
if (task != null)
task.run();
Expand Down

0 comments on commit 013ae3c

Please sign in to comment.