Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

SSL flaky on NGINX Ingress Controller (0.9.0-beta8) #212

Closed
cguethle opened this issue Jun 19, 2017 · 4 comments
Closed

SSL flaky on NGINX Ingress Controller (0.9.0-beta8) #212

cguethle opened this issue Jun 19, 2017 · 4 comments

Comments

@cguethle
Copy link

I haven't diagnosed this fully, but I'm seeing issues with kube-lego 1.4 correctly setting up the ingress on 0.9.0-beta8. It feels like it is close to working, but requires a restart of the nginx-ingress-controller pod after deploying a new ingress with the appropriate tls/etc specified. Prior on 1.3+0.8.3, everything worked as expected (no restart necessary).

Has there been any 1.4 validation on 0.9.0 yet? Not complaining, just curious. :)

I will post more details if I can figure them out, but kube-lego + nginx-ingress-controller is magic to me, so will see.

@munnerz
Copy link
Contributor

munnerz commented Jul 5, 2017

This sounds like a problem with the new implementation of nginx-ingress not automatically reloading it's config upon secret changes.

kube-lego itself does not inform nginx-ingress to reload directly, it simply updates the TLS secret object. It's then the responsibility of the ingress controller to trigger a reload of it's own config in a timely manner.

With regards validation the two, not as far as I'm aware. There's definitely not tests for it within the kube-lego repository yet at least.

I'm going to close this issue for now, as the comments in the corresponding issue on the nginx repository seem to show that the secret itself is being created successfully, which is the extent of kube-lego's responsibility. Feel free to open if you think I've been hasty with that conclusion!

@munnerz munnerz closed this as completed Jul 5, 2017
@aledbf
Copy link
Contributor

aledbf commented Jul 6, 2017

@cguethle I cannot reproduce this with kube-lego 0.1.5 and nginx-ingress-controller 0.9-beta.10.

Please keep in mind that after kube-lego generates the certificate and the new secret is detected in the ingress controller it can take up to 10 seconds to reload the ingress controller.

@cguethle
Copy link
Author

cguethle commented Jul 6, 2017

I will update tomorrow and test my setup.

@juliohm1978
Copy link

We have a new installation here. Fresh pods, new cert successfully issued. But nginx-ingress-controller:0.9-beta.10 continues to ignore and does not reload.

Can someone, please reopen the issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants