Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Some null handling wart #39

Merged
merged 4 commits into from
Apr 14, 2020
Merged

Remove Some null handling wart #39

merged 4 commits into from
Apr 14, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Mar 5, 2020

Some null renders as null atm; as evidenced by the diffs, removing that wart makes for less special cases in tests re #38

@bartelink
Copy link
Collaborator Author

@ylibrach any insights much appreciated ;)

@bartelink
Copy link
Collaborator Author

Hm; conditional serialization is not a thing in System.Text.Json v 4.7; there's no reasonable way to implement such a special case
Also, going down the rathole has removed any desire I have to special case it - I've simply noted that Some null is not a roundtrippable value.

@bartelink bartelink marked this pull request as ready for review April 14, 2020 16:34
@bartelink bartelink merged commit 1366dc3 into stj Apr 14, 2020
@bartelink bartelink deleted the somenull branch April 14, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant