Improve exception handling #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not be extracted. We simply print and error message an exit with a error code
generating stack trackback when expected errors happen
',' as delimiters and stripping white spaces
This warranty the order of output messages send to the console
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed the raise of exceptions to avoid generating stack tracebacks on the console output. Instead, error messages are printed and the script exits on an error code. Error messages are also prefixed with
ERROR:for clarify, and they are send tostderr.stdin,stdoutandstderrare forced to be totally unbuffered, to preserve the order of messages in the logs.The handling of input argument is improved as well. The scripts makes sure that the GitHub token is not empty, and the list of labels are converted to python list, using
,as delimiter and stripping white spaces.Additionally, this PR clarifies the use of the
pull-request-numerinput, which is mandatory when the action is trigger usingpull_request_target.This resolves #19