-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Do not comment when valid labels are present #6
Comments
@abergs I forked this and removed the comment on success. Unfortunately, you're still going to get notifications for a review approval which is what I was trying to avoid. |
That comments are pure spam as they stack, rendering the action undesirable for any practical use. I hope this will be addressed soon. |
@abergs @ssbarnea @mstrk I ended up using this action: https://github.com/mheap/github-action-required-labels No comments, and the author also optimized it with |
@NathanielHill thx for the heads-up. cheers 🖖 |
@abergs @NathanielHill @ssbarnea @mstrk Thank you for the feedback. After this change, the action now looks back at the review history and check what was the state of the previous review done by itself (if any), and avoid doing the same action again (for example, if the previous review was approved, and the label are still correct, then the action does not do apply a new review to the PR. Likewise for the opposite case where the last review requested changes and the label are still missing). This will prevent having multiple reviews as @NathanielHill mentioned. I also removed the I just released a new version of this action with this new feature: v1.2.0. Thanks you all. |
Thank you @jesusvasquez333 |
Hi!
First of all, thank you. I just implemented this action and it really help us.
However, on any changes on the PR the action keeps commenting that valid labels are present. I would like it to just approve the change.
E.g: passwordless-lib/fido2-net-lib#175
The text was updated successfully, but these errors were encountered: