Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Do not comment when valid labels are present #6

Closed
abergs opened this issue May 28, 2020 · 6 comments · Fixed by #12
Closed

Feature: Do not comment when valid labels are present #6

abergs opened this issue May 28, 2020 · 6 comments · Fixed by #12
Labels
enhancement New feature or request

Comments

@abergs
Copy link

abergs commented May 28, 2020

Hi!

First of all, thank you. I just implemented this action and it really help us.
However, on any changes on the PR the action keeps commenting that valid labels are present. I would like it to just approve the change.

E.g: passwordless-lib/fido2-net-lib#175

@NathanielHill
Copy link

@abergs I forked this and removed the comment on success. Unfortunately, you're still going to get notifications for a review approval which is what I was trying to avoid.

@ssbarnea
Copy link

That comments are pure spam as they stack, rendering the action undesirable for any practical use. I hope this will be addressed soon.

@NathanielHill
Copy link

@abergs @ssbarnea @mstrk I ended up using this action: https://github.com/mheap/github-action-required-labels

No comments, and the author also optimized it with ncc so it takes about 2 seconds to run!

@mstrk
Copy link

mstrk commented Jul 21, 2020

@NathanielHill thx for the heads-up.

cheers 🖖

@jesusvasquez333
Copy link
Owner

@abergs @NathanielHill @ssbarnea @mstrk Thank you for the feedback.
I agree that the way it was implemented was very annoying, and it was incorrect to keep commenting the same result. So, I addressed this issue in #12 .

After this change, the action now looks back at the review history and check what was the state of the previous review done by itself (if any), and avoid doing the same action again (for example, if the previous review was approved, and the label are still correct, then the action does not do apply a new review to the PR. Likewise for the opposite case where the last review requested changes and the label are still missing). This will prevent having multiple reviews as @NathanielHill mentioned.

I also removed the body of the approval review. Now you will see only one approval notification, without comments in it. I kept whoever the body of the review that request changes.

I just released a new version of this action with this new feature: v1.2.0.

Thanks you all.

@jesusvasquez333 jesusvasquez333 added the enhancement New feature or request label Sep 12, 2020
@abergs
Copy link
Author

abergs commented Sep 14, 2020

Thank you @jesusvasquez333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants