Update regex replace to not require full path matching #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Doh. I'll fix up the flow issues. |
Current coverage is 89.94% (diff: 100%)@@ master #1723 diff @@
==========================================
Files 31 31
Lines 1144 1144
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1029 1029
Misses 115 115
Partials 0 0
|
|
This looks great. Nice work @zackargyle |
mthmulders
pushed a commit
to mthmulders/jest
that referenced
this pull request
Oct 10, 2016
* Update regex replace to not require full path matching * Fix flow issue * Code style
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Update regex replace to not require full path matching * Fix flow issue * Code style
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The config option
moduleNameMappercurrently requires a full path match. This is because it is doing a regex replace on the original module name. This diff changes that so that instead we are using the mapped name directly. This makes it much easier to match any file of a specific type: like'\\.css'. There will be a small backwards compatability possibility for matches that depended on the previously incorrect behavior. (I found one such case in the Pinterest codebase that was resolved by using requireActual instead, which was more correct anyway).The previous functionality is:
Before
After
Test plan
I ran the changes over the 900 Pinterest tests as well as the jest codebase tests. I also added a test to make sure that the path is used correctly.
#1624